Sitelet https://github.com/starkware-libs/cairo/pull/9915
Skip to content

docs(corelib): use public ops paths in index deprecation notes - #9915

Merged
orizi merged 2 commits into
starkware-libs:mainfrom
ml0mbardi:public-ops-index-deprecation-paths
May 11, 2026
Merged

orizi merged 2 commits into
starkware-libs:mainfrom
ml0mbardi:public-ops-index-deprecation-paths

Conversation

@ml0mbardi

Copy link
Copy Markdown
Contributor

This updates deprecated-index-traits notes to reference core::ops::Index and IndexView, keeping deprecation guidance aligned with the public trait paths.

@cursor

cursor Bot commented May 9, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk: only updates deprecation note strings/formatting for Index/IndexView, with no behavioral or API changes beyond compiler guidance text.

Overview
Updates the deprecated-index-traits guidance for Index and IndexView to reference the public core::ops::Index/core::ops::IndexView paths (instead of core::ops::index::...) in both the v2023_10 prelude re-exports and the trait definitions.

Also normalizes the #[deprecated(...)] attribute formatting for these items (no functional changes).

Reviewed by Cursor Bugbot for commit f33a5ba. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@orizi orizi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ml0mbardi).

@orizi orizi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ml0mbardi).


a discussion (no related file):
fix cairo-fmt.
https://github.com/starkware-libs/cairo/actions/runs/25604347632/job/75165878364?pr=9915

@orizi orizi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ml0mbardi).

@orizi
orizi enabled auto-merge May 11, 2026 12:08

@orizi orizi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ml0mbardi).

@orizi
orizi added this pull request to the merge queue May 11, 2026
Merged via the queue into starkware-libs:main with commit c02125a May 11, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants