You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BoundedInt is changed from pub(crate) visibility to fully pub, making it part of the public API.
Type of change
Please check one:
Bug fix (fixes incorrect behavior)
New feature
Performance improvement
Documentation change with concrete technical impact
Style, wording, formatting, or typo-only change
⚠️ Note:
To keep maintainer workload sustainable, we generally do not accept PRs that
are only minor wording, grammar, formatting, or style changes.
Such PRs may be closed without detailed review.
Why is this change needed?
BoundedInt was previously restricted to crate-internal use only, preventing external consumers from referencing or using this type directly. Exposing it publicly allows downstream users and libraries to leverage bounded integer types in their own code.
What was the behavior or documentation before?
BoundedInt<MIN, MAX> was declared pub(crate), meaning it could only be used within the corelib crate itself.
What is the behavior or documentation after?
BoundedInt<MIN, MAX> is now declared pub, making it accessible to any external crate or user code that imports it from corelib::internal::bounded_int.
Related issue or discussion (if any)
Additional context
Note that BoundedIntGuarantee remains pub(crate) and is not affected by this change.
Low Risk
Low implementation risk (visibility-only change), but it expands the public API surface so downstream code may start depending on corelib::internal::bounded_int::BoundedInt.
Overview
Makes BoundedInt<MIN, MAX> in corelib/src/internal/bounded_int.cairopublic (from pub(crate) to pub), allowing external crates to name and use the bounded integer type. BoundedIntGuarantee remains crate-private; no functional logic changes are included.
Reviewed by Cursor Bugbot for commit 4252dae. Bugbot is set up for automated code reviews on this repo. Configure here.
The reason will be displayed to describe this comment to others. Learn more.
@TomerStarkware reviewed 1 file and all commit messages, and made 1 comment. Reviewable status: complete! all files reviewed, all discussions resolved (waiting on orizi).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TomerStarkware
left a comment
complete! all files reviewed, all discussions resolved (waiting on orizi).
Summary
BoundedIntis changed frompub(crate)visibility to fullypub, making it part of the public API.Type of change
Please check one:
Why is this change needed?
BoundedIntwas previously restricted to crate-internal use only, preventing external consumers from referencing or using this type directly. Exposing it publicly allows downstream users and libraries to leverage bounded integer types in their own code.What was the behavior or documentation before?
BoundedInt<MIN, MAX>was declaredpub(crate), meaning it could only be used within thecorelibcrate itself.What is the behavior or documentation after?
BoundedInt<MIN, MAX>is now declaredpub, making it accessible to any external crate or user code that imports it fromcorelib::internal::bounded_int.Related issue or discussion (if any)
Additional context
Note that
BoundedIntGuaranteeremainspub(crate)and is not affected by this change.