Conversation
|
This change is |
orizi
left a comment
There was a problem hiding this comment.
@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.
a discussion (no related file):
@TomerStarkware for 2nd eye.
orizi
left a comment
There was a problem hiding this comment.
@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Keemosty12).
crates/cairo-lang-semantic/src/cache/mod.rs line 1242 at r1 (raw file):
TypeCached::ImplType(impl_type) => TypeLongId::ImplType(impl_type.embed(ctx)), TypeCached::FixedSizeArray(type_id, size) => TypeLongId::FixedSizeArray { type_id: type_id.embed(ctx),
run ./scripts/rust_fmt.sh.
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Keemosty12 and orizi).
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Keemosty12).
This changes
TypeCached::FixedSizeArrayto storeConstValueIdCachedforsize, reusing the existing const-value lookup and avoiding duplicated embedded const payloads.