Optimized sha256 padding code. - #9360
Merged
Merged
Conversation
|
This change is |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 of 5 tasks
orizi
force-pushed
the
orizi/12-27-optimized_sha256_padding_code
branch
from
December 27, 2025 18:52
e32d32c to
2f1c950
Compare
orizi
marked this pull request as ready for review
December 27, 2025 22:33
TomerStarkware
approved these changes
Dec 28, 2025
TomerStarkware
left a comment
Collaborator
There was a problem hiding this comment.
@TomerStarkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware).
orizi
changed the base branch from
orizi/12-25-removed_various_todos
to
graphite-base/9360
December 28, 2025 15:13
orizi
force-pushed
the
graphite-base/9360
branch
from
December 28, 2025 15:13
fe467e0 to
f7b306f
Compare
orizi
force-pushed
the
orizi/12-27-optimized_sha256_padding_code
branch
from
December 28, 2025 15:13
2f1c950 to
ff6d810
Compare
Princetimix69
pushed a commit
to Princetimix69/cairo
that referenced
this pull request
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved performance of sha256 padding phase.
Involved only a single store of the padded value, and using bounded ints for calculation of required values.
Type of change
Please check one:
Why is this change needed?
Sha256 padding had worse performance than possible.
What was the behavior or documentation before?
Higher gas consumption and larger code.
What is the behavior or documentation after?
Smaller and more efficient code.