Refactored s check and improved failure in recover_public_key. - #9142

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)

corelib/src/ecdsa.cairo line 202 at r1 (raw file):

/// Checks if `value != 0` (mod stark_curve::ORDER).
fn is_equivalent_to_zero(value: felt252) -> bool {
    value == 0 || value == ec::stark_curve::ORDER

Suggestion:

 // Note that 2*ec::stark_curve::ORDER > felt252 PRIME
 value == 0 || value == ec::stark_curve::ORDER

@ilyalesokhin-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

@ilyalesokhin-starkware reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @orizi)

@orizi reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)