Sitelet https://github.com/starkware-libs/cairo/pull/10121/files
Skip to content

bugfix(semantic): Removed extra diagnostic for type mismatches on missing. #10121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orizi merged 1 commit into from
Jun 18, 2026
Merged

bugfix(semantic): Removed extra diagnostic for type mismatches on missing. #10121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/cairo-lang-semantic/src/items/imp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2732,7 +2732,7 @@ fn validate_impl_item_constant<'db>(

let expected_ty = inference.rewrite(concrete_trait_constant_ty).no_err();
let actual_ty = inference.rewrite(constant_ty).no_err();
if expected_ty != actual_ty {
if expected_ty != actual_ty && !expected_ty.is_missing(db) && !actual_ty.is_missing(db) {
diagnostics.report(
impl_constant_type_clause_ast.ty(db).stable_ptr(db),
WrongType { expected_ty, actual_ty },
Expand Down
29 changes: 29 additions & 0 deletions crates/cairo-lang-semantic/src/items/tests/trait_const
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,3 +844,32 @@ impl SomeImpl of SomeTrait {
}

//! > expected_diagnostics

//! > ==========================================================================

//! > Test impl const with an unresolvable type reports only the resolution error (no spurious

//! > type-mismatch cascade).

//! > test_runner_name
test_function_diagnostics(expect_diagnostics: true)

//! > function_code
fn foo() {}

//! > function_name
foo

//! > module_code
trait MyTrait {
const X: u32;
}
impl MyImpl of MyTrait {
const X: Nonexistent = 0;
}

//! > expected_diagnostics
error[E0006]: Type not found.
--> lib.cairo:5:14
const X: Nonexistent = 0;
^^^^^^^^^^^
Loading