bugfix(compiler): Fix punctuation/newline of bare crate-root diagnostics. - #10087
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview The Reviewed by Cursor Bugbot for commit c61ce65. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a57a343592
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ics.
The "Failed to get main module file" and "{path} not found" messages
reported when a crate's main module file is missing were inconsistent
with every other diagnostic: the former lacked a trailing newline (so
it ran into following output, since FormattedDiagnosticEntry's Display
adds none and entries are emitted via eprint!), and both lacked the
trailing period that diagnostic messages conventionally carry. Add the
missing newline and periods.
a57a343 to
c61ce65
Compare
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on eytan-starkware).
Summary
Adds a trailing period to two diagnostic error messages:
"Failed to get main module file"and"{path} not found".Type of change
Please check one:
Why is this change needed?
Other diagnostic error messages in the codebase end with a period for consistency. These two messages were missing the trailing period, making them inconsistent with the rest of the diagnostic output.
What was the behavior or documentation before?
Error messages read:
"Failed to get main module file""{path} not found"What is the behavior or documentation after?
Error messages read:
"Failed to get main module file.""{path} not found."Related issue or discussion (if any)
Additional context