You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes the diagnostic message for a missing comma in single-element tuple expressions. The ParserDiagnosticKind::MissingToken was referencing SyntaxKind::TokenComma instead of SyntaxKind::TerminalComma, which caused the error message to display Missing token TokenComma. instead of the human-readable Missing token ','.
Type of change
Please check one:
Bug fix (fixes incorrect behavior)
New feature
Performance improvement
Documentation change with concrete technical impact
Style, wording, formatting, or typo-only change
Why is this change needed?
The diagnostic emitted when a single-element tuple is missing its trailing comma was referencing the wrong SyntaxKind variant (TokenComma instead of TerminalComma). This caused the error message to expose an internal token kind name rather than the expected human-readable punctuation character.
What was the behavior or documentation before?
When writing a single-element tuple without a trailing comma (e.g., (felt252)), the parser emitted:
Low Risk
One-line diagnostic kind fix in the parser with an updated snapshot test; no parsing or semantic behavior change.
Overview
Fixes the missing trailing comma diagnostic for single-element type tuples in expect_type_tuple_expr (e.g. return type (felt252) instead of (felt252,)).
The parser now passes SyntaxKind::TerminalComma into ParserDiagnosticKind::MissingToken, aligning with other missing-terminal diagnostics that use terminal kinds so the message shows Missing token ','. rather than the internal label TokenComma. Parser test expectations for function_signature were updated accordingly.
Reviewed by Cursor Bugbot for commit 981228d. Bugbot is set up for automated code reviews on this repo. Configure here.
The reason will be displayed to describe this comment to others. Learn more.
@TomerStarkware reviewed 2 files and all commit messages, and made 1 comment. Reviewable status: complete! all files reviewed, all discussions resolved (waiting on eytan-starkware).
orizi
deleted the
orizi/06-08-bugfix_parser_improved_missing_comma_diag
branch
June 9, 2026 08:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TomerStarkware
left a comment
complete! all files reviewed, all discussions resolved (waiting on eytan-starkware).
Summary
Fixes the diagnostic message for a missing comma in single-element tuple expressions. The
ParserDiagnosticKind::MissingTokenwas referencingSyntaxKind::TokenCommainstead ofSyntaxKind::TerminalComma, which caused the error message to displayMissing token TokenComma.instead of the human-readableMissing token ','.Type of change
Please check one:
Why is this change needed?
The diagnostic emitted when a single-element tuple is missing its trailing comma was referencing the wrong
SyntaxKindvariant (TokenCommainstead ofTerminalComma). This caused the error message to expose an internal token kind name rather than the expected human-readable punctuation character.What was the behavior or documentation before?
When writing a single-element tuple without a trailing comma (e.g.,
(felt252)), the parser emitted:What is the behavior or documentation after?
The parser now correctly emits:
Related issue or discussion (if any)
N/A
Additional context
N/A