Sitelet https://github.com/starkware-libs/cairo/pull/10030
Skip to content

feat: dev and rc tags are not marked as latest release - #10030

Merged
orizi merged 1 commit into
mainfrom
orizi/dev-rc-not-latest
Jun 3, 2026
Merged

feat: dev and rc tags are not marked as latest release#10030
orizi merged 1 commit into
mainfrom
orizi/dev-rc-not-latest

Conversation

@orizi

@orizi orizi commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Adds prerelease and make_latest flags to the GitHub release workflow. Releases with rc in the tag are marked as pre-releases, and only releases that do not contain dev or rc in the tag are marked as the latest release.

Type of change

Please check one:

  • Bug fix (fixes incorrect behavior)
  • New feature
  • Performance improvement
  • Documentation change with concrete technical impact
  • Style, wording, formatting, or typo-only change

Why is this change needed?

Release candidates (rc) were being published as full stable releases and marked as the latest release, which could mislead users into treating pre-release versions as stable.

What was the behavior or documentation before?

All releases, including release candidates and dev builds, were published without any pre-release designation and were all eligible to be marked as the latest release.

What is the behavior or documentation after?

  • Tags containing rc are published as pre-releases.
  • Only tags that contain neither dev nor rc are marked as the latest release.

Related issue or discussion (if any)

N/A

Additional context

N/A

@reviewable-StarkWare

reviewable-StarkWare commented Jun 3, 2026

Copy link
Copy Markdown

This change is Reviewable

@orizi Graphite App

orizi commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@orizi
orizi marked this pull request as ready for review June 3, 2026 10:38
@cursor

cursor Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
CI-only change to GitHub release metadata flags; no runtime or compiler behavior.

Overview
GitHub release uploads now set pre-release and latest based on the pushed tag name.

Tags whose ref string includes rc are published as pre-releases. Only tags that include neither dev nor rc are marked as the repository’s latest release, so dev and RC builds no longer replace stable releases as “Latest.”

Reviewed by Cursor Bugbot for commit 89c9860. Bugbot is set up for automated code reviews on this repo. Configure here.

TomerStarkware
TomerStarkware approved these changes Jun 3, 2026
View reviewed changes

@TomerStarkware TomerStarkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@TomerStarkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on eytan-starkware).

@orizi
orizi enabled auto-merge June 3, 2026 10:42
@orizi
orizi added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit e259ddb Jun 3, 2026
54 checks passed
@orizi
orizi deleted the orizi/dev-rc-not-latest branch June 3, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomerStarkware TomerStarkware TomerStarkware approved these changes
@eytan-starkware eytan-starkware Awaiting requested review from eytan-starkware

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@orizi @reviewable-StarkWare @TomerStarkware