Revert "Mark file unsaved when a missing image is relocated" - #1758
Open
phkahler wants to merge 1 commit into
Open
Revert "Mark file unsaved when a missing image is relocated"#1758phkahler wants to merge 1 commit into
phkahler wants to merge 1 commit into
Conversation
This reverts commit 52c21e2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 52c21e2.
That "fixed" issue #1238 which it did while introducing new bugs by introducing a new flag that was not properly handled. I think it best to revert that entirely and make a clean fix. Unfortunately that one is quite far back in the history at this point, so I think it best to use a second commit to revert it rather than trying to rewrite the history since then.