improvement(workflow): add compact code hover previews - #7074
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR adds compact, syntax-highlighted previews for clipped workflow code values and extends the shared code viewer and popover styling to support them.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported keyboard and touch accessibility gap is addressed by focusable dialog semantics, explicit activation controls, focus retention, and regression coverage.
|
| Filename | Overview |
|---|---|
| packages/workflow-renderer/src/lib/code-hover-card.tsx | Implements the interactive preview with clipped-content gating, keyboard and touch activation, focus retention, delayed pointer transitions, and Escape handling. |
| packages/workflow-renderer/src/lib/overflow-span.tsx | Routes code values to the new rich hover card while preserving the existing tooltip path for ordinary clipped text. |
| packages/emcn/src/components/code/code.tsx | Adds compact read-only viewer density while keeping virtualized and non-virtualized line sizing aligned. |
| apps/sim/lib/workflows/blocks/code-preview.ts | Produces previews only for non-password, non-empty string code fields and normalizes supported syntax languages. |
| packages/workflow-renderer/src/lib/overflow-span-mount.test.tsx | Covers delayed pointer opening, pointer transfer into the preview, keyboard focus and Escape behavior, and touch toggling. |
Reviews (2): Last reviewed commit: "fix(workflow): address code preview revi..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist