improvement(tables): inline column creation and header-menu editing by j15z · Pull Request #7048 · simstudioai/sim

j15z · 2026-08-24T20:35:59Z

Summary

Columns are created inline: pick a type from "+ New column", name it in the header, press Enter. Nothing persists until the name commits, so Escape or a reload before that leaves nothing behind
Select columns open the options sidebar only after the name commits; Save persists name + options in one create, Cancel/X/another panel discards the draft
Column editing moves out of the sidebar into the header menu: Rename column, a Change type submenu (converting to Select opens the options sidebar), Set/Remove unique, and Configure select/currency for per-type settings. The sidebar no longer carries name or type fields
Invalid names are refused in place with a toast and red text instead of surfacing as a raw contract error
Fixes an infinite recursion in the date display formatter (a number retyped to date, e.g. 100, overflowed the stack and tripped the table error boundary); every registry formatter is now guarded by a totality test
Fixes the "+ New column" menu stealing focus from the draft input during its exit animation, the draft cell collapsing the add-column cell (missing <col> in the fixed layout), and the column flicker after creation (create response is now written to the schema cache on success)

Type of Change

Improvement

Testing

Tested manually. bun run lint, block-registry check, bun run check:audits, type-check, and 1,633 table/query tests pass. Playwright probes cover instant create, invalid/duplicate names, reload-before-naming, select save/cancel/abandon, type changes, and the layout/flicker cases.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-08-24T20:36:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 24, 2026 9:33pm

cursor · 2026-08-24T20:36:18Z

PR Summary

Medium Risk
Touches core table schema mutations, column create/update flows, and undo replay; changes are UX-heavy but include formatter and cache-timing fixes that affect grid stability.

Overview
Column creation and editing move into the grid header. Picking a scalar type from "+ New column" now mounts a draft header for naming; nothing hits the API until the name commits (Escape or leaving the flow drops the draft). Select columns open the options sidebar only after a valid name, then persist name + options in one create. The config sidebar is narrowed to select options / multiselect, currency code, and convert-to-select — name, type, and unique are no longer edited there.

The column chevron menu gains Rename, Change type (select conversions route through the options sidebar), Set/Remove unique (registry-driven), and Configure for types with hasConfiguration. Plain column header clicks only select; workflow outputs still open their sidebar on click.

Validation and polish: columnNameIssue refuses bad/duplicate names in the header with toast + red text. The new-column dropdown defers onPickType until after close to avoid Radix stealing focus; draft columns get their own <col> so layout does not collapse. useAddTableColumn writes the create response into the detail cache immediately to avoid post-create flicker.

Fixes: Date formatDateCellDisplay no longer recurses on values like 100 after retype to date (totality tests on formatters). Undo/redo for create-column and type changes now carries full column metadata.

^{Reviewed by Cursor Bugbot for commit 6ece736. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-08-24T20:39:15Z

Greptile Summary

The PR moves table-column creation and editing into inline headers and header menus while retaining sidebars for type-specific configuration.

Adds deferred inline column drafts with validation, cancellation, layout handling, and schema-cache reconciliation.
Adds header-menu actions for rename, type conversion, uniqueness, and select/currency configuration.
Updates undo state and column-type formatting tests, including a guard against recursive date formatting.

Confidence Score: 5/5

The PR appears safe to merge because the previously reported import-path issue is fixed and no blocking failure remains.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/headers/draft-column-header.tsx	Adds the local draft-name input and now uses the requested absolute `@/` import for `ColumnTypeIcon`.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx	Coordinates draft-column lifecycle, inline rename validation, persistence, type changes, layout, and undo recording.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-config-sidebar/column-config-sidebar.tsx	Narrows the sidebar to select and currency configuration, including draft-select creation and select conversion.
apps/sim/hooks/queries/tables.ts	Updates table mutation cache behavior to reconcile created and edited schema data.
apps/sim/hooks/use-table-undo.ts	Extends undo handling to retain complete created-column definitions and type-change state.
apps/sim/lib/table/dates.ts	Makes date display formatting total for invalid numeric conversions and avoids recursive formatting failure.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Pick[Pick new column type] --> Draft[Create local header draft]
  Draft -->|Escape or reload| Discard[Discard without persistence]
  Draft -->|Commit scalar name| Create[Persist column]
  Draft -->|Commit select name| Options[Open options sidebar]
  Options -->|Save| Create
  Options -->|Cancel or replace panel| Discard
  Header[Existing column header menu] --> Rename[Rename inline]
  Header --> Type[Change type]
  Header --> Unique[Set or remove unique]
  Header --> Configure[Configure select or currency]

_{Reviews (2): Last reviewed commit: "fix(tables): preserve column actions acr..." | Re-trigger Greptile}

j15z · 2026-08-24T21:33:55Z

@greptile

j15z · 2026-08-24T21:34:01Z

@cursor review

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 6ece736. Configure here.}

cursor · 2026-08-24T21:44:29Z

    },
    onSettled: () => {
-      invalidateTableSchemaOnly(queryClient, tableId)
+      queryClient.invalidateQueries({ queryKey: tableKeys.lists() })


Create drops schema refetch

Medium Severity

useAddTableColumn writes result.data.columns into the detail cache on success but no longer invalidates or cancels the detail query. An in-flight detail fetch that started earlier can finish afterward and overwrite that write with a pre-create schema, so the new column disappears until some later unrelated refetch.

^{Reviewed by Cursor Bugbot for commit 6ece736. Configure here.}

cursor · 2026-08-24T21:44:29Z

+
+  draftSelectSaveSinkRef.current = (options, multiple) =>
+    persistDraft({ options, ...(multiple ? { multiple: true } : {}) })
+  abortColumnDraftSinkRef.current = () => setColumnDraft(null)


Escape clears saving draft

Medium Severity

handleDraftCancel always clears columnDraft and does not consult draftPersistingRef / draftSelectSavingRef. During an in-flight select save, Escape can drop the draft while slideout CLOSE stays blocked, so a failed create leaves the options sidebar open with nothing left for Save to persist.

Additional Locations (1)

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx#L242-L249

^{Reviewed by Cursor Bugbot for commit 6ece736. Configure here.}

j15z · 2026-08-26T01:54:35Z

Closing as superseded by the narrower sidebar-based Reference column implementation on https://github.com/simstudioai/sim/tree/feat/table-fks. Column creation and configuration now live in the sidebar; inline renaming, Edit column, and pinning remain.

vercel Bot temporarily deployed to Preview August 24, 2026 20:36 Inactive

greptile-apps Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread ...rkspace/[workspaceId]/tables/[tableId]/components/table-grid/headers/draft-column-header.tsx Outdated

cursor Bot reviewed Aug 24, 2026

View reviewed changes

j15z added 2 commits August 24, 2026 14:29

improvement(tables): inline column creation and header-menu editing

7d8e4c0

fix(tables): preserve column actions across undo

6ece736

j15z force-pushed the fix/revert-table-side-column branch from 8990821 to 6ece736 Compare August 24, 2026 21:32

vercel Bot temporarily deployed to Preview August 24, 2026 21:33 Inactive

cursor Bot reviewed Aug 24, 2026

View reviewed changes

j15z closed this Aug 26, 2026

waleedlatif1 deleted the fix/revert-table-side-column branch August 26, 2026 03:13

Navigation Menu

Uh oh!

improvement(tables): inline column creation and header-menu editing - #7048

improvement(tables): inline column creation and header-menu editing#7048
j15z wants to merge 2 commits into
stagingfrom
fix/revert-table-side-column

j15z commented Aug 24, 2026

Uh oh!

vercel Bot commented Aug 24, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Aug 24, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Aug 24, 2026 •

edited

Loading

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

j15z commented Aug 24, 2026

Uh oh!

j15z commented Aug 24, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Aug 24, 2026

Uh oh!

cursor Bot Aug 24, 2026

Uh oh!

j15z commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

j15z commented Aug 24, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

j15z commented Aug 24, 2026

Uh oh!

j15z commented Aug 24, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Aug 24, 2026

Choose a reason for hiding this comment

Create drops schema refetch

Uh oh!

cursor Bot Aug 24, 2026

Choose a reason for hiding this comment

Escape clears saving draft

Uh oh!

j15z commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Aug 24, 2026 •

edited

Loading

cursor Bot commented Aug 24, 2026 •

edited

Loading

greptile-apps Bot commented Aug 24, 2026 •

edited

Loading