Sitelet https://github.com/signnow/SignNow.NET/pull/147
Skip to content

Fix validation limits, add thumbnails - #147

Merged
AlexNDRmac merged 2 commits into
developfrom
fix-validation
Jan 23, 2023
Merged

AlexNDRmac merged 2 commits into
developfrom
fix-validation

Conversation

@AlexNDRmac

Copy link
Copy Markdown
Contributor

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Link to issue (if exists):

Small description of changes:

Added

  • The Thumbnail property on Model.SignNowDocument, which allows you to get document thumbnails in small, medium and large image sizes

Fixed

  • Fixed fails when parsing error response from auth service #134

Changed

  • Removed built-in validation for LinkExpiration

Thanks

@codecov

codecov Bot commented Jan 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #147 (54c0b45) into develop (c527e88) will increase coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #147      +/-   ##
===========================================
+ Coverage    99.07%   99.22%   +0.14%     
===========================================
  Files           60       60              
  Lines         1300     1293       -7     
===========================================
- Hits          1288     1283       -5     
+ Misses          12       10       -2     

@AlexNDRmac
AlexNDRmac merged commit fd17024 into develop Jan 23, 2023
@AlexNDRmac
AlexNDRmac deleted the fix-validation branch January 23, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant