Conversation
Contributor
|
Hi bilyush, As said by @OlegIlyenko , this needs to be moved lower in the hierarchy (in But the question is mainly what to do with test modules? They are overwriting the basic value in the main module using the thing we are trying to fix. One of the solutions may be the creation of the separated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #69
I would propose to allow the user specify the behaviour: should the error be thrown in ambiguous case or not. The proposed trait can be stacked into Modules, where that make sence, and at the same time do not affect the existing implementations. Thanks @Mironor for the initial effort (#70)
Qustions:
Looking forward for @OlegIlyenko and @Mironor feedback and discussion.