Repository navigation
Conversation
rv-jenkins
added a commit
that referenced
this pull request
Mar 1, 2021
rv-jenkins
added a commit
that referenced
this pull request
Mar 11, 2021
* web/k-web-theme: 9314777 - For RV Website generating pages and blog (#3) * web/k-web-theme: c995d8e - fix: Fixed few markdown preview styles (#4) * web/k-web-theme: 2139b52 - Updated few functions for building the HTML files (#5) * web/k-web-theme: 9c5dccf - fix: Fixed the code block styling in dark mode (#6) * web/k-web-theme: 090f448 - Moved public_content dir from web-common to k-web-theme static_content (#7)
dwightguth
pushed a commit
that referenced
this pull request
Apr 19, 2024
Previously we were parsing the json tests in python, then converting them to KORE and passing them to the backend which then used the kore parser to parse them. This is fairly inefficient, because we end up parsing things twice. The solution is pretty straightforward. We simply send the entire json file to the backend as a single `String`, then invoke the llvm backend's json parser, which is extremely fast, on the resulting term. It's a fairly basic change, but it significantly improves performance. Time on the base branch: ``` real 6m21.214s user 75m41.967s sys 3m35.565s ``` Time on the branch containing the change: ``` real 5m23.010s user 46m6.622s sys 2m47.065s ```
dwightguth
pushed a commit
that referenced
this pull request
Jun 18, 2024
Previously we were parsing the json tests in python, then converting them to KORE and passing them to the backend which then used the kore parser to parse them. This is fairly inefficient, because we end up parsing things twice. The solution is pretty straightforward. We simply send the entire json file to the backend as a single `String`, then invoke the llvm backend's json parser, which is extremely fast, on the resulting term. It's a fairly basic change, but it significantly improves performance. Time on the base branch: ``` real 6m21.214s user 75m41.967s sys 3m35.565s ``` Time on the branch containing the change: ``` real 5m23.010s user 46m6.622s sys 2m47.065s ```
dwightguth
pushed a commit
that referenced
this pull request
Jun 18, 2024
Previously we were parsing the json tests in python, then converting them to KORE and passing them to the backend which then used the kore parser to parse them. This is fairly inefficient, because we end up parsing things twice. The solution is pretty straightforward. We simply send the entire json file to the backend as a single `String`, then invoke the llvm backend's json parser, which is extremely fast, on the resulting term. It's a fairly basic change, but it significantly improves performance. Time on the base branch: ``` real 6m21.214s user 75m41.967s sys 3m35.565s ``` Time on the branch containing the change: ``` real 5m23.010s user 46m6.622s sys 2m47.065s ```
dwightguth
pushed a commit
that referenced
this pull request
Jun 18, 2024
Previously we were parsing the json tests in python, then converting them to KORE and passing them to the backend which then used the kore parser to parse them. This is fairly inefficient, because we end up parsing things twice. The solution is pretty straightforward. We simply send the entire json file to the backend as a single `String`, then invoke the llvm backend's json parser, which is extremely fast, on the resulting term. It's a fairly basic change, but it significantly improves performance. Time on the base branch: ``` real 6m21.214s user 75m41.967s sys 3m35.565s ``` Time on the branch containing the change: ``` real 5m23.010s user 46m6.622s sys 2m47.065s ```
dwightguth
pushed a commit
that referenced
this pull request
Jun 25, 2024
Previously we were parsing the json tests in python, then converting them to KORE and passing them to the backend which then used the kore parser to parse them. This is fairly inefficient, because we end up parsing things twice. The solution is pretty straightforward. We simply send the entire json file to the backend as a single `String`, then invoke the llvm backend's json parser, which is extremely fast, on the resulting term. It's a fairly basic change, but it significantly improves performance. Time on the base branch: ``` real 6m21.214s user 75m41.967s sys 3m35.565s ``` Time on the branch containing the change: ``` real 5m23.010s user 46m6.622s sys 2m47.065s ```
Robertorosmaninho
pushed a commit
that referenced
this pull request
Oct 15, 2024
Previously we were parsing the json tests in python, then converting them to KORE and passing them to the backend which then used the kore parser to parse them. This is fairly inefficient, because we end up parsing things twice. The solution is pretty straightforward. We simply send the entire json file to the backend as a single `String`, then invoke the llvm backend's json parser, which is extremely fast, on the resulting term. It's a fairly basic change, but it significantly improves performance. Time on the base branch: ``` real 6m21.214s user 75m41.967s sys 3m35.565s ``` Time on the branch containing the change: ``` real 5m23.010s user 46m6.622s sys 2m47.065s ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ehildenb Please review and merge. I'm rebasing all my stuff on this commit now.