Repository navigation
Add CONTRIBUTING.md with repo guidance and test instructions - #1
Merged
Merged
Conversation
Covers where changes belong across all repos, test commands, protocol authority rules, and PR expectations. https://claude.ai/code/session_01ERtvZVdXvpELAKdknquqD4
- Remove false Spring AI integration claim from spring-boot-starter description (no Spring AI dependency exists in that repo) - Soften AUDIT.md language to "where present" since not all client repos have one yet (TypeScript client lacks it) https://claude.ai/code/session_01ERtvZVdXvpELAKdknquqD4
- Add cycles-server-admin to "Where Changes Belong" - Add protocol spec validation (Spectral linting via make validate) - Add cycles-server-admin test command (mvn verify with integration-tests profile) - Add docs build/dev commands (VitePress) https://claude.ai/code/session_01ERtvZVdXvpELAKdknquqD4
- Python: add ruff and mypy steps (CI runs all three on 3.10/3.12) - TypeScript: add typecheck and lint steps, document coverage thresholds (95% lines, 85% branches) and CI matrix (Node 20/22) - Java server: note Docker/TestContainers requirement for tests - Admin server: show unit tests (no Docker) separately from integration tests (Docker required) - Spring starter: note mock-based tests, 85% JaCoCo threshold - PR expectations: add reminder to run full lint+test suite locally https://claude.ai/code/session_01ERtvZVdXvpELAKdknquqD4
3 tasks
This was referenced May 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comprehensive
CONTRIBUTING.mdfile to establish clear guidelines for contributors across the RunCycles monorepo. The document provides guidance on where different types of changes belong, how to run tests for each component, and expectations for pull requests.Key Changes
cycles-protocol-v0.yamlis the source of truth and that implementations must conform to the specAUDIT.mdupdates,README.mdupdates, and pre-submission test runsNotable Details
https://claude.ai/code/session_01ERtvZVdXvpELAKdknquqD4