Expose .idl to DDS .idl conversion via rosidl translate CLI - #55
Merged
Merged
Conversation
20 of 21 tasks
hidmic
force-pushed
the
hidmic/rosidl-translate-dds-idl
branch
from
March 1, 2021 23:54
5bc231d to
36f6362
Compare
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/rosidl-translate-dds-idl
branch
from
March 9, 2021 14:59
36f6362 to
1242d04
Compare
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Contributor
|
The CI job needs a release https://build.ros2.org/job/Rpr__rosidl_dds__ubuntu_focal_amd64/5/ for |
Contributor
|
@osrf-jenkins retest this please |
Contributor
Author
Indeed! Edit: ros/rosdistro#28525 is up |
Contributor
|
@osrf-jenkins retest this please |
ahcorde
approved these changes
Mar 10, 2021
Contributor
Author
|
Running CI up to
|
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Contributor
Author
|
Re-running Windows CI after 4bbea01:
|
Contributor
Author
|
Alright, CI's green, reviewer is OK with this patch. Going in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rosidl#565. Depends on ros2/rosidl#575.