feat(web): generate layer style property table from the style spec - #4313
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SY4pX3Uqk9xHo6LK9svAjV
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before: web layers used a hand-written list of layout props and treated every other prop as paint, so props like
iconImageortextFieldwere sent as paint.After:
yarn generatewritessrc/web/utils/webStyleMap.tsfrom the style spec, and web layers look up each prop's spec name and kind (paint or layout) there. Unknown props are warned about and skipped.scripts/templates/webStyleMap.ts.ejs, in the same pass asstyleMap.ts.toGLStyleuses the generated table;*Transitionprops still map to<name>-transition.Checklist
yarn generatein the root folder/exampleapp (web, Chromium): circle and line layers withlineCap, a color transition and a style switch render with no warnings.