Conversation
A sample of 1.5 was cast to a negative 16-bit value, so the activity check heard a wrapped signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trim_long_silencespacks the waveform as 16-bit samples for the voice activity check. A sample of1.5came back as-16386, and-1.5came back as16386. The values wrap past the 16-bit range, so the check hears a different signal.Out-of-range samples are clipped.
1.5stays32767.-1.5stays-32767.1.0,-1.0, and0.0stay32767,-32767, and0.Test plan
test_out_of_range_samples_do_not_wrapis red on the old cast (1.5is-16386) and green after the clip1.0,-1.0, and0.0are unchanged