Refactor/input type numbet to type text inputmode decimal#37 - #68
Open
Lukecsharpwalker wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Gerome Grignon Team on Vercel. A member of the Team first needs to authorize it. |
Lukecsharpwalker
force-pushed
the
refactor/input-type-numbet-to-type-text-inputmode-decimal#37
branch
from
June 20, 2026 18:27
801d0ce to
44c8edd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap type="number" for type="text" inputmode="decimal" on the three numeric fields (basePrice, quantity, tip.customAmount), and forward inputmode through the shared rw-input wrapper.
Motivation: addresses issue #37, following Angular commit 41b1410 (Signal Forms now supports binding number|null to ); type="number" has known UX drawbacks; inputmode alone on the call site had no effect because rw-input didn't forward it to the inner .