Move some tests from failing to passing except dev - #9711
Merged
Merged
Conversation
sophiebits
approved these changes
May 18, 2017
These throw because we're asserting on the warnings. Make this not throw so that they instead only fail to assert the warnings.
sebmarkbage
force-pushed
the
makewarningnotfail
branch
from
May 18, 2017 06:37
d1273f3 to
35edf43
Compare
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
These throw because we're asserting on the warnings. Make this not throw so that they instead only fail to assert the warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These throw because we're asserting on the warnings. Make this not throw so that they instead only fail to assert the warnings.
We don't warn for this in the new server renderer atm.