[docs] Update "Profiling Components with Chrome Timeline" - #9602
Conversation
As of Chrome 58, the Timeline tab is now called the Performance tab, this updates the "Optimizing Performance > Profiling Components with Chrome Performance" section of the docs to reflect that.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
@facebook-github-bot sorry I just signed it! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| Remember that you only need to do this for production builds. You shouldn't apply `UglifyJsPlugin` or `DefinePlugin` with `'production'` value in development because they will hide useful React warnings, and make the builds much slower. | ||
|
|
||
| ## Profiling Components with Chrome Timeline | ||
| ## Profiling Components with Chrome Performance |
There was a problem hiding this comment.
Nitpick:
"Profiling Components with Chrome Performance" reads funny to me. What about something like: "Profiling Components with the Chrome Performance Tab"
There was a problem hiding this comment.
Yep no problem, I'll fix that up then resolve & merge with master 👍
|
@himynameisdave Do you mind resolving the conflicts with master? |
|
@nhunzaker all cleaned up now 👍 |
|
Looks great. Thank you for your contribution! |
|
@nhunzaker Please add "needs merge to stable" label to merged doc PRs, or changes won't appear until React 16. |
|
Ah. Thanks! Will do. |
As of Chrome 58, the Timeline tab is now called the Performance tab, this updates the "Optimizing Performance > Profiling Components with Chrome Performance" section of the docs to reflect that. (cherry picked from commit 5cf5718)
As of Chrome 58, the Timeline tab is now called the Performance tab, this updates the "Optimizing Performance > Profiling Components with Chrome Performance" section of the docs to reflect that. (cherry picked from commit 5cf5718)
As of Chrome 58, the Timeline tab is now called the Performance tab, this updates the "Optimizing Performance > Profiling Components with Chrome Performance" section of the docs to reflect that.
As of Chrome 58, the Timeline tab is now called the Performance tab, this updates the "Optimizing Performance > Profiling Components with Chrome Performance" section of the docs to reflect that.
Resolves #9601