Added explicit null return to completeUnitOfWork() to resolve Flow error - #9299
Merged
Merged
Conversation
acdlite
reviewed
Mar 30, 2017
| } | ||
| } | ||
|
|
||
| // Without this explicit null return Flow complains of invalid return type |
Collaborator
There was a problem hiding this comment.
Let's add a todo here so that we come back and remove while (true)
acdlite
approved these changes
Mar 30, 2017
bvaughn
force-pushed
the
flow-fix-scheduler
branch
from
March 30, 2017 22:42
434e82b to
5e3ac42
Compare
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
completeUnitOfWorkcauses Flow errors because of thiswhile (true)loop:Here is a smaller repro.
Maybe we should remove or reconsider this
whileloop but for now I've fixed the issue by adding an explicitnullreturn outside of the loop. (It was blocking a merge in fbsource so I fixed it there and this is an upstream sync.)