Show more meanignful stack trace for ReactNative errors - #9291
Merged
bvaughn merged 5 commits intoMar 30, 2017
Merged
Conversation
Clicking on the stack should jump to where the error actually occurred rather than to where it's logged in a redbox component.
gaearon
reviewed
Mar 30, 2017
|
|
||
| exports.injection = { | ||
| injectDialog(fn: (e: CapturedError) => void) { | ||
| injectDialog(fn: (e: CapturedError) => ?boolean) { |
Contributor
There was a problem hiding this comment.
Maybe let's make it strict?
… ExceptionManager
bvaughn
force-pushed
the
ReactNativeFiberErrorDialog-upstream-sync
branch
from
March 30, 2017 17:35
37a4f3c to
36fd48d
Compare
Contributor
Author
|
Going ahead and merging based on Tim's approval of this same change-set in fbsource. |
|
💯 ship.it |
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
* Show more meanignful stack trace for ReactNative errors Clicking on the stack should jump to where the error actually occurred rather than to where it's logged in a redbox component. * Made showDialog() return type stricter. Added mock and Flow types for ExceptionManager * Prettier * Handle null/string thrown errors * Removed unused reference to emptyFunction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is an upstream sync from a change committed to fbsource.)
Clicking on the stack should jump to where the error actually occurred rather than to where it's logged in a redbox component.
Before
After