Conversation
The query parser now raises `Rack::QueryParser::IncompatibleEncodingError` if we try to parse params that are not ASCII compatible. (cherry picked from commit 603b799)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2416 to
3-2-stable, as agreed in #2510.Released versions still raise a bare
Encoding::CompatibilityErrorout ofRequest#POSTfor a multipart part whose
charsetis not ASCII compatible. Since that is not aRack::BadRequest, middleware that guards param parsing — includingRack::MethodOverride— cannot rescue it, and it escapes the application's error handling entirely.
Clean cherry-pick apart from the changelog entry, which is placed under the existing
### Fixedheading here.Not backported to
3-1-stable, per @jeremyevans: that branch is in security maintenancemode.
🤖 Generated with Claude Code