You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the emissions.csv files to Dutch regional dataset, imported from ETDataset as result of the Dutch regional data pipeline.
Implemented changes
Data pipeline related:
New data pipeline added for Dutch regional datasets. Emissieregistratie is used as source applies and conversion steps are applied to generate the required CSV format.
Automatic validation is done in the data pipeline.
Intermediate emissions.csv are exported for manual checks.
README added
Restructering of folders in the tools/emissions folder
The reason will be displayed to describe this comment to others. Learn more.
Looks good. To be able to run the model locally I had to (locally) rebase with master. I didn't push this but since there were no conflicts it should be fine to merge.
I haven't had the time to look into these PRs. One thing that I did not already is the role and data pipeline for 1.A.3.e (Other transportation). It requires further investigation. I had AI summarise some of the discussion:
Flag for review: possible double counting of 1.A.3.e (Other transportation).
In ETSource, transport_non_specified is mapped to CRT code 1.A.3 (all of transport), while other_other_transportation is a separate 1.A.3.e subsector. Both are in the direct_emissions group and both are summed. In ETDataset-public, the ETLocal key energetic_emissions_other_ghg_transport takes the full 1.A.3 total (greenhouse_gas_emissions.xlsx, Sectors!O16) and does not subtract 1.A.3.e. The NL municipal mapping (all_ghg_mapping.csv) also assigns gas transport N₂O (1.A.3.e.i) to that transport key. As a result, any regional dataset that also gets a value for other_other_transportation will count 1.A.3.e twice. For the country emissions.csv files, 1.A.3.e matches the EEA data exactly, but the transport value matches neither full 1.A.3 nor 1.A.3 minus 1.A.3.e. Someone needs to check in the pipeline whether 1.A.3.e is subtracted from transport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR updates the emissions.csv files to Dutch regional dataset, imported from ETDataset as result of the Dutch regional data pipeline.
Implemented changes
Data pipeline related:
Related
Goes with:
Checklist