Sitelet https://github.com/qoretechnologies/toolkit-react/pull/125
Skip to content

fix(form-engine): a read row with an object value names it and previews its keys - #125

Merged
nickmazurenko merged 1 commit into
developfrom
bugfix/read-row-object-values
Sep 24, 2026
Merged

nickmazurenko merged 1 commit into
developfrom
bugfix/read-row-object-values

Conversation

@nickmazurenko

Copy link
Copy Markdown
Contributor

What

A FormEngine read row whose value is a data provider summarised it as 11 fields — a count that reads like a string and says nothing about which provider the value is. Reported by Filip on qorus-ide Qlip builds #204–#208 (Components/Variables/Editor · Read Only Variable: "Initial value says 11 fields like it's a string or something — we need to better visualize it's actually an object / a complex value").

Two changes in the read-first engine:

  • readFirst.ts — formatDataProviderValue names a provider the way the picker shows it: kind · name · path (datasource · omquser · /bb_local). formatOptionValue uses it for the data-provider type before falling back to the key count.
  • CompactRow.tsx — the hash row's structured preview now also applies to rows whose declared type holds a plain object: data-provider, options, system-options, processor-mappings. The list is explicit because a schema or richtext value is an object too and already has a preview of its own. Develop's rule that an expression stored as an AST is never previewed as a hash applies to these rows as well.

A string row gets no preview — the preview follows the shape of the value, not the read mode.

Before / after

Before: Initial value 11 fields
After: Initial value datasource · omquser · /bb_local with type / name / transaction_management / path / … one Show more away.

Coverage

  • __tests__/readRowObjectValue.test.tsx — the reported case (names the provider, previews its keys, and the scalar row beside it stays one line).
  • __tests__/readFirst.test.ts — formatDataProviderValue shapes.
  • Story Form/Engine/FormEngine → Compact Read Only Data Provider with a play asserting the same three things; Qlip picks it up as a new snapshot.

Version

0.10.56 (last published beta is 0.10.55).

Follow-up in qorus-ide

Bump reqraft once this is released, then accept the Variables Read Only Variable capture that has carried Filip's rejection since build #204.

…ws its keys

A data-provider row in read mode summarised its value as "11 fields": a
count that reads like a string and says nothing about which provider the
value is. The hash row already drew a structured preview under its summary;
the data-provider row did not, because the preview was keyed on the declared
type rather than on the shape of the value.

The summary now names the provider ("datasource · omquser · /bb_local"), and
a row whose declared type holds a plain object — data-provider, options,
system-options, processor-mappings — gets the same structured preview a hash
row has, so the keys are one disclosure away.
@github-actions

Copy link
Copy Markdown

📦 Prerelease published for this PR:

@qoretechnologies/reqraft@0.10.56-pr.125.g8140ccd

Install it in a consumer (updates package.json + lockfile):

yarn add @qoretechnologies/reqraft@0.10.56-pr.125.g8140ccd

Published under the pr dist-tag — latest/beta are untouched. Repoint consumers to the released version once this PR merges.

@qlip-qore-technologies

qlip-qore-technologies Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

qlip visual regression

🔍 1 changed, 1 new of 527 snapshots.
✅ All changes approved.

Review build 20260924-004338 in the dashboard →

@nickmazurenko
nickmazurenko merged commit 1690562 into develop Sep 24, 2026
4 checks passed
@nickmazurenko
nickmazurenko deleted the bugfix/read-row-object-values branch September 24, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant