Use log-level debug for smartdevice query error reporting - #1587
Merged
Conversation
21 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1587 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 157 157
Lines 9630 9630
Branches 976 976
=======================================
Hits 8930 8930
Misses 499 499
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Oct 26, 2025
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Nov 10, 2025
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently logging query failures to the error logger, which causes log spam if a device is intentionally unavailable.
This PR will change the log-level for connection errors to debug to silence this for common downstream scenarios.
A follow-up PR could be made to report connection errors (i.e., if no module can be queried) by raising an exception for downstream uses.
Related to home-assistant/core#143667