Restore license file for offline package builds - #337
Draft
cananoo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #336.
The source repository no longer included the Apache-2.0 license file after the
license metadata migration. Package builds therefore relied on
coherent.licensed, which downloads the license text from the internet duringthe build.
This restores the historical license file and removes the build plugin. With
Setuptools 77 or later, the source license file is included in both the sdist
and wheel license metadata without a network request from this plugin.
Validation:
python -m pytest -q -p no:ruff(216 passed, 1 skipped)ruff check .using Ruff 0.12.0python -m build --no-isolation -qLICENSEand do notreference
coherent.licensed.git diff --checkI used OpenAI Codex to assist with investigating and preparing this change,
and reviewed the resulting code, packaging metadata, and artifacts before
submission.