Use of uninitialized pointer in Argument Clinic generated code

The code generated for the Py_UNICODE converter (and derived converter LPCWSTR) looks like:

const Py_UNICODE *name;
...
if (!_PyArg_ParseXXX(..., name, ...)) {
    goto exit;
}
...
exit:
    PyMem_Free((void *)name);

If parsing fails, PyMem_Free() is called for uninitialized variable.

It is the only converter with non-trivial cleanup which does not have a mandatory initializer.

Seems that for now it only affects the Windows code.

I have found this bug when tried to use Argument Clinic for OS agnostic code which converts arguments to wchar_t * (in getpath.c).

pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py…

These needs to be fixed if _winapi.CreateJunction() is used as a fallback for os.symlink() when creating a compatibility link such as "bin -> Scripts". More here: #97586 (comment).

gh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICO…

[3.11] pythongh-97728: Argument Clinic: Fix uninitialized variable in…

[3.11] gh-97728: Argument Clinic: Fix uninitialized variable in the P…

[3.10] pythongh-97728: Argument Clinic: Fix uninitialized variable in…

[3.10] gh-97728: Argument Clinic: Fix uninitialized variable in the P…

Merge branch 'main' into dictwatch

Fixed by #97729

Navigation Menu

Repository navigation

Use of uninitialized pointer in Argument Clinic generated code #97728

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Use of uninitialized pointer in Argument Clinic generated code #97728

Description

Activity

serhiy-storchaka commented on Oct 2, 2022

eryksun commented on Oct 2, 2022

kumaraditya303 commented on Oct 16, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions