test_itertools.py does not test infinite iterable for itertools.chain.from_iterable #93814

Activity

1. youknowone

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Jun 14, 2022
2. AlexWaygood

   added

   testsTests in the Lib/test dirTests in the Lib/test dir

   on Jun 14, 2022
3. AlexWaygood

   assigned

   rhettinger

   on Jun 14, 2022
4. rhettinger commented on Jun 14, 2022

   

   rhettinger

   on Jun 14, 2022

   Contributor

   More actions

   ISTM there is no point in adding another test for this. Infinite iterators a just a special case of "bigger than you can reasonably consume".

   From a consumers point of view, there is no way to differentiate an infinite iterator from a huge iterator (c.f. the halting problem).
5. youknowone commented on Jun 14, 2022

   

   youknowone

   on Jun 14, 2022

   Last edited by youknowone

   ContributorAuthor

   More actions

   The test will prevent a potential regression to evaluate given iterable before consuming.

   Please let me know if there is a test already covers a huge iterator.
   I found test_long_chain_of_empty_iterables is a similar one, but it doesn't fully prevent it.

   ref: RustPython/RustPython#3787
6. miss-islington

   closed this as completedin #93815on Jun 14, 2022
7. miss-islington

   added a commit that references this issue on Jun 14, 2022

   gh-93814: Add infinite test for itertools.chain.from_iterable (GH-93815)

   ...

   274769c
8. serhiy-storchaka

   added a commit that references this issue on Jun 26, 2022

   Revert 30935 defer bpo45162 to 312 (#94285)

   ...

   1ffde3e