Sitelet https://github.com/python/cpython/issues/83728
Skip to content

hmac.new() default parameter change not mentioned in changelog #83728

Description

@wbond
mannequin
BPO 39547
Nosy @wbond

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-02-03.22:59:34.267>
labels = ['3.8', 'docs']
title = 'hmac.new() default parameter change not mentioned in changelog'
updated_at = <Date 2020-02-03.22:59:34.267>
user = 'https://github.com/wbond'

bugs.python.org fields:

activity = <Date 2020-02-03.22:59:34.267>
actor = 'wbond'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation']
creation = <Date 2020-02-03.22:59:34.267>
creator = 'wbond'
dependencies = []
files = []
hgrepos = []
issue_num = 39547
keywords = []
message_count = 1.0
messages = ['361329']
nosy_count = 2.0
nosy_names = ['docs@python', 'wbond']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue39547'
versions = ['Python 3.8']

Activity

  1. wbond commented on Feb 3, 2020

    wbondmannequin
    MannequinAuthor

    When running code on Python 3.8 that previous was running 3.3, I ran into the issue that the default value for the digestmod parameter of hmac.new() has been changed to backwards-incompatible value.

    I generally would have expected such a break to show up in https://docs.python.org/3/whatsnew/3.8.html#api-and-feature-removals. If not there, somewhere on the 3.8 changelog page.

  2. added
    docsDocumentation in the Doc dir
    on Feb 3, 2020
  3. transferred this issue fromon Apr 10, 2022
  4. slateny commented on Apr 25, 2022

    @slateny
    Contributor

    The removal does seem mentioned under the function section, but I wonder if it should be also noted in the changelog

  5. tiran commented on Apr 25, 2022

    @tiran
    Member

    It's documented in the 3.4 changelog, https://docs.python.org/3/whatsnew/3.4.html#hmac

  6. tiran commented on Apr 25, 2022

    @tiran
    Member

    I would not object to add a note to the "porting to 3.8" section.

  7. added a commit that references this issue on Jun 6, 2022
  8. added 3 commits that reference this issue on Jun 6, 2022
  9. added 4 commits that reference this issue on Jun 6, 2022
  10. ambv commented on Jun 6, 2022

    @ambv
    Contributor

    Fixed in 3.8+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.8 (EOL)end of lifedocsDocumentation in the Doc dir

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions