Sitelet https://github.com/python/cpython/issues/81057
Skip to content

[subinterpreters] Global C variables are a problem #81057

Closed
Closed
[subinterpreters] Global C variables are a problem#81057
Assignees
ericsnowcurrently
Labels
3.8 (EOL)end of lifetopic-subinterpreterstype-bugAn unexpected behavior, bug, or error

Description

@ericsnowcurrently
ericsnowcurrently
opened on May 10, 2019
BPO 36876
Nosy @vsajip, @vstinner, @tiran, @phsilva, @ericsnowcurrently, @soltysh, @pablogsal, @sweeneyde
PRs
  • bpo-36876: Avoid static locals. #13372
  • bpo-36876: Use a consistent variable name for kwlist. #13531
  • bpo-36876: Make some static string literal arrays constant. #15760
  • bpo-36876: Add a tool that identifies unsupported global C variables. #15877
  • bpo-36876: Skip test_check_c_globals for now. #16017
  • bpo-36876: Fix the globals checker tool. #16058
  • bpo-36876: Moved Parser/listnode.c statics to interpreter state. #16328
  • bpo-36876: Re-organize the c-analyzer tool code. #16841
  • bpo-36876: Fix the C analyzer tool. #22841
  • bpo-36876: Small adjustments to the C-analyzer tool. #23045
  • bpo-36876: [c-analyzer tool] Tighten up the results and output. #23431
  • bpo-36876: [c-analyzer tool] Add a "capi" subcommand to the c-analyzer tool. #23918
  • bpo-36876: [c-analyzer tool] Additional CLI updates for "capi" command. #23929
  • bpo-36876: Update the c-analyzer whitelist. #31225
  • bpo-36876: Minor cleanup to c-analyzer "ignored" data.' #31239
  • bpo-36876: Make sure the c-analyzer is checking all the source files.' #31264
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericsnowcurrently'
closed_at = None
created_at = <Date 2019-05-10.19:01:42.087>
labels = ['expert-subinterpreters', 'type-bug', '3.8']
title = '[subinterpreters] Global C variables are a problem'
updated_at = <Date 2022-02-10.23:14:23.025>
user = 'https://github.com/ericsnowcurrently'

    bugs.python.org fields:

    activity = <Date 2022-02-10.23:14:23.025>
actor = 'eric.snow'
assignee = 'eric.snow'
closed = False
closed_date = None
closer = None
components = ['Subinterpreters']
creation = <Date 2019-05-10.19:01:42.087>
creator = 'eric.snow'
dependencies = []
files = []
hgrepos = []
issue_num = 36876
keywords = ['patch']
message_count = 22.0
messages = ['342119', '342125', '352013', '352032', '352063', '352085', '352208', '354928', '356181', '357351', '357352', '357353', '368910', '379390', '379999', '381511', '383698', '383778', '393785', '412886', '412957', '413029']
nosy_count = 8.0
nosy_names = ['vinay.sajip', 'vstinner', 'christian.heimes', 'phsilva', 'eric.snow', 'maciej.szulik', 'pablogsal', 'Dennis Sweeney']
pr_nums = ['13372', '13531', '15760', '15877', '16017', '16058', '16328', '16841', '22841', '23045', '23431', '23918', '23929', '31225', '31239', '31264']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue36876'
versions = ['Python 3.8']

    Activity

    1. ericsnowcurrently commented on May 10, 2019

      @ericsnowcurrently
      ericsnowcurrently
      on May 10, 2019
      MemberAuthor

      We still have a bunch of "global" C variables (static globals, static locals, maybe thread-local storage) in our code-base that break the isolation between interpreters. I added Tools/c-globals/check-c-globals.py a while back to help identify such variables, however more have crept in. I also did not take static locals or thread-locals into account.

      To address the above, we should do the following:

      1. update check-c-globals.py to identify static locals (and thread-locals)
      2. deal with any identified globals
      3. add check-c-globals.py to "make check"
      4. (if "make check" isn't already there), ensure check-c-globals.py is run at some point in CI

      Separately, we should move fields out of _PyRuntimeState into PyInterpreterState wherever possible. That can also be done at step 2 if it's not too much work.

    2. ericsnowcurrently
      added
      interpreter-core(Objects, Python, Grammar, and Parser dirs)
      3.8 (EOL)end of life
      on May 10, 2019
    3. ericsnowcurrently
      self-assigned this
      on May 10, 2019
    4. ericsnowcurrently
      added
      type-bugAn unexpected behavior, bug, or error
      on May 10, 2019

    5. ericsnowcurrently commented on May 10, 2019

      @ericsnowcurrently
      ericsnowcurrently
      on May 10, 2019
      MemberAuthor

      Also, Tools/c-globals/ignored-globals.txt is a bit out of date (some vars have been removed, renamed, or moved to another file). That should get cleaned up. It might also make sense to update check-c-globals.py to verify that all variables in ignored-globals.txt actually exist.

    6. ericsnowcurrently commented on Sep 11, 2019

      @ericsnowcurrently
      ericsnowcurrently
      on Sep 11, 2019
      MemberAuthor

      New changeset ee536b2 by Eric Snow in branch 'master':
      bpo-36876: Add a tool that identifies unsupported global C variables. (bpo-15877)
      ee536b2

    7. db3l commented on Sep 11, 2019

      @db3l
      db3l
      on Sep 11, 2019
      Contributor

      The new test_check_c_globals.ActualChecks test is failing with an "unexpected success" on the bolen-ubuntu buildbot (under Ubuntu 18.04.3). I can reproduce the failure in a manually built tree.

    8. ericsnowcurrently commented on Sep 12, 2019

      @ericsnowcurrently
      ericsnowcurrently
      on Sep 12, 2019
      MemberAuthor

      @db3l, I'll take a look right away.

    9. ericsnowcurrently commented on Sep 12, 2019

      @ericsnowcurrently
      ericsnowcurrently
      on Sep 12, 2019
      MemberAuthor

      New changeset 64535fc by Eric Snow in branch 'master':
      bpo-36876: Skip test_check_c_globals for now. (gh-16017)
      64535fc

    10. ericsnowcurrently commented on Sep 12, 2019

      @ericsnowcurrently
      ericsnowcurrently
      on Sep 12, 2019
      MemberAuthor

      New changeset 088b63e by Eric Snow in branch 'master':
      bpo-36876: Fix the globals checker tool. (gh-16058)
      088b63e

    11. ericsnowcurrently commented on Oct 19, 2019

      @ericsnowcurrently
      ericsnowcurrently
      on Oct 19, 2019
      MemberAuthor

      New changeset e4c431e by Eric Snow in branch 'master':
      bpo-36876: Re-organize the c-analyzer tool code. (gh-16841)
      e4c431e

    12. vsajip commented on Nov 7, 2019

      @vsajip
      vsajip
      on Nov 7, 2019
      Member

      New changeset 9def81a by Vinay Sajip in branch 'master':
      bpo-36876: Moved Parser/listnode.c statics to interpreter state. (GH-16328)
      9def81a

    13. ericsnowcurrently commented on Nov 23, 2019

      @ericsnowcurrently
      ericsnowcurrently
      on Nov 23, 2019
      MemberAuthor

      Thanks, Vinay!

    14. ericsnowcurrently commented on Nov 23, 2019

      @ericsnowcurrently
      ericsnowcurrently
      on Nov 23, 2019
      MemberAuthor

      FYI, others have been tackling this in separate issues (e.g. Victor, anyone relative to PEP-384).

    15. 44 remaining items

    16. ericsnowcurrently
      added 4 commits that reference this issue on Dec 12, 2022

      gh-81057: Move tracemalloc Globals to _PyRuntimeState (gh-100151)

      8790d4d

      gh-81057: Move faulthandler Globals to _PyRuntimeState (gh-100152)

      53d9cd9

      gh-81057: Move Signal-Related Globals to _PyRuntimeState (gh-100085)

      5eb28bc

      gh-81057: Move _Py_RefTotal to the "Ignored Globals" List (gh-100203)

      0e081a0
    17. carljm
      added a commit that references this issue on Dec 14, 2022

      Merge branch 'main' into typedocs

      53d33a1
    18. pablogsal
      added a commit that references this issue on Dec 16, 2022

      gh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (#100277)

      0415cf8
    19. carljm
      added a commit that references this issue on Dec 16, 2022

      Merge branch 'main' into fastmock

      2260a54
    20. shihai1991
      added a commit that references this issue on Dec 18, 2022

      Merge remote-tracking branch 'origin/main' into bpo_34697

      2878571
    21. ericsnowcurrently
      added 2 commits that reference this issue on Mar 9, 2023

      gh-81057: Vendor a Subset of distutils for the c-analyzer Tool (gh-10…

      ca066bd

      gh-81057: Add a CI Check for New Unsupported C Global Variables (gh-1…

      1ff81c0
    22. carljm
      added a commit that references this issue on Mar 14, 2023

      Merge branch 'main' into inlinecomp2

      6c5f269
    23. Fidget-Spinner
      added a commit that references this issue on Mar 27, 2023

      pythongh-81057: Add a CI Check for New Unsupported C Global Variables (…

      038b67c
    24. warsaw
      added a commit that references this issue on Apr 11, 2023

      pythongh-81057: Add a CI Check for New Unsupported C Global Variables (…

      e20008f
    25. ericsnowcurrently
      closed this as completedon May 3, 2023
    26. github-project-automation
      moved this from Todo to Done in Subinterpreterson May 3, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    3.8 (EOL)end of lifetopic-subinterpreterstype-bugAn unexpected behavior, bug, or error

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions