Sitelet https://github.com/python/cpython/issues/107262
Skip to content

Tkinter: test failure due to Tk 8.6.14 listbox bugfix #107262

Closed
Closed
Tkinter: test failure due to Tk 8.6.14 listbox bugfix#107262
Assignees
serhiy-storchaka
Labels
topic-tkintertype-bugAn unexpected behavior, bug, or error

Description

@chrstphrchvz
chrstphrchvz
opened on Jul 25, 2023

The current output of the itemconfigure command for listbox widgets falsely suggests that the configuration of listbox items is influenced by the options database (if I understand correctly). This will be fixed in Tk 8.6.14: see https://core.tcl-lang.org/tk/info/ed8eae599d76 and https://core.tcl-lang.org/tk/vdiff?from=edf00be1&to=025022a4

Although tkinter.Listbox.itemconfigure() will still work properly, test.test_tkinter.test_widgets.ListboxTest.test_itemconfigure will fail since it expects the erroneous output:

======================================================================
FAIL: test_itemconfigure (test.test_tkinter.test_widgets.ListboxTest.test_itemconfigure)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/user/git/cpython/Lib/test/test_tkinter/test_widgets.py", line 1002, in test_itemconfigure
    self.assertEqual(widget.itemconfigure(0, 'background'),
AssertionError: Tuples differ: ('background', '', '', '', 'red') != ('background', 'background', 'Background', '', 'red')

First differing element 1:
''
'background'

- ('background', '', '', '', 'red')
+ ('background', 'background', 'Background', '', 'red')

Linked PRs

Activity

  1. chrstphrchvz
    added
    type-bugAn unexpected behavior, bug, or error
    on Jul 25, 2023
  2. AlexWaygood
    added
    topic-tkinter
    on Jul 25, 2023
  3. terryjreedy
    assigned
    serhiy-storchaka
    on Jul 26, 2023

  4. terryjreedy commented on Jul 26, 2023

    @terryjreedy
    terryjreedy
    on Jul 26, 2023
    Member

    I have no experience with the options database. Are we currently testing for buggy behavior?

  5. serhiy-storchaka commented on Jul 26, 2023

    @serhiy-storchaka
    serhiy-storchaka
    on Jul 26, 2023
    Member

    We are currently testing for the current behavior. They change Tk tests, so we should also change corresponding Tkinter tests. Either make them more lenient, so they will pass on all version (we can use mock.ANY for this), or expect different result depending on the Tk patch level, or only test this assertion on the fixed Tk with the correct result. The exact value is not so important as its "form" -- we test that itemconfigure() can take two arguments and return a 5-tuple, its first item is the option name and its last item is the current value.

    Do you want to create a PR @chrstphrchvz?

  6. serhiy-storchaka
    added a commit that references this issue on May 30, 2024

    gh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (GH-119322)

    9732ed5
  7. miss-islington
    added 2 commits that reference this issue on May 30, 2024

    pythongh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (pythonGH-119322

    cff5cf4

    pythongh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (pythonGH-119322

    67add33
  8. serhiy-storchaka
    added 2 commits that reference this issue on May 30, 2024

    [3.13] gh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (GH-119322) (G…

    978b86a

    [3.12] gh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (GH-119322) (G…

    bd0d97c
  9. serhiy-storchaka
    closed this as completedon May 31, 2024
  10. noahbkim
    added a commit that references this issue on Jul 11, 2024

    pythongh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (pythonGH-119322

    4921429
  11. estyxx
    added a commit that references this issue on Jul 17, 2024

    pythongh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (pythonGH-119322

    63e2cbb
  12. hugovk
    added 2 commits that reference this issue on Feb 18, 2025

    pythongh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (pythonGH-119322

    44060ae

    pythongh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (pythonGH-119322

    0a1b0f0

  13. hugovk commented on Feb 18, 2025

    @hugovk
    hugovk
    on Feb 18, 2025
    Member

    We need to backport this to 3.9, because it's still using ubuntu-20.04 which is deprecated and will be fully unsupported in April: actions/runner-images#11101.

    And the upgrade to newer Ubuntu also upgrades Tk.

  14. miss-islington
    added 3 commits that reference this issue on Feb 18, 2025

    pythongh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (pythonGH-119322

    fc3836e

    pythongh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (pythonGH-119322

    212dc8f

    pythongh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (pythonGH-119322

    b89238c
  15. hugovk
    added 3 commits that reference this issue on Feb 19, 2025

    [3.11] gh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (GH-119322) (#…

    9d727fe

    [3.10] gh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (GH-119322) (#…

    4413f2e

    [3.9] gh-107262: Update Tkinter tests for Tcl/Tk 8.6.14 (GH-119322) (#…

    61746a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

topic-tkintertype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions