Conversation
Author
|
Oh well, closing in favor of #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is at least one edge case where there is no event loop when https://github.com/pytest-dev/pytest-asyncio/compare/master...argaen:catch_when_no_loop?expand=1#diff-4d85e8313d8e67cb777137411a11ac86R133 is reached.
When combining pytest-aiohttp and this package (only with 0.6.0 version) tests are crashing saying there is no event loop running. I believe the error is produced because pytest-aiohttp does the following: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/pytest_plugin.py#L145 and then when pytest-asyncio reaches the line where it has to get the loop, there is no loop. This PR provides a try/except for controlling this case.
I was checking previous versions of this package to see why it wasn't crashing but from what I can see it has changed quite a lot