Sitelet https://github.com/processing/p5.js-sound/pull/312
Skip to content

Added saveSoundToBlob() to soundRecorder.js - #312

Merged
therewasaguy merged 1 commit into
processing:masterfrom
wahengchang:master
Aug 7, 2018
Merged

therewasaguy merged 1 commit into
processing:masterfrom
wahengchang:master

Conversation

@wahengchang

Copy link
Copy Markdown
Contributor

as my need is recording sound by microphone, then appending it to DOM for preview before it is downloaded. a temporary blob url is the choice.

@therewasaguy

Copy link
Copy Markdown
Member

thank you @wahengchang ! This will close https://github.com/processing/p5.js-sound/issues/257

@therewasaguy

Copy link
Copy Markdown
Member

as part of a related issue (https://github.com/processing/p5.js-sound/issues/314) we may want to move these away from the p5.prototype to the SoundFile

@therewasaguy
therewasaguy merged commit feb4bd3 into processing:master Aug 7, 2018
@wahengchang

wahengchang commented Aug 9, 2018 •

Copy link
Copy Markdown
Contributor Author

@therewasaguy , when can I use the new version included this Pull-Request ?
I need it desperately

@therewasaguy

therewasaguy commented Aug 11, 2018 •

Copy link
Copy Markdown
Member

@wahengchang you can use it now by compiling p5 sound from source, and it will be included in the next release of p5.js, tho I'd like to move this (and saveSound) to p5.SoundFile / p5.SoundRecorder, before we make it part of the official API. Let me know if you have any thoughts on that, I'm about to take a look!

@therewasaguy

Copy link
Copy Markdown
Member

^ #315 would move saveBlob to SoundFile. I think that's the best home for this method?

@wahengchang

wahengchang commented Aug 12, 2018 •

Copy link
Copy Markdown
Contributor Author

I left a comment :)

@therewasaguy therewasaguy mentioned this pull request Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants