Stronger wordHighlightBorder - #40
Conversation
| "editor.selectionHighlightBackground": "#17E5E600", | ||
| "editor.selectionHighlightBorder": "#17E5E644", | ||
| "editor.wordHighlightBackground": "#17E5E633", | ||
| "editor.wordHighlightStrongBackground": "#17E5E622", |
There was a problem hiding this comment.
I intentionally put less focus on the strong word highlight than on the regular one for those reasons:
- It's good to distinguish between the word where my cursor is and all the other occurrences to make it easier to navigate through the file.
- However, we need to distinguish between a highlight and a selection, so the contrast between those needs to be sufficient as well. Making the
stronghighlight more transparent helps a lot here. - When we're searching for occurrences, we're not so much interested in the
strongone.
Problems this could make:
- Distracts from the place where we placed our cursor. I hope that won't be too much of an issue as the currently selected line gets its own highlight.
simurai
left a comment
There was a problem hiding this comment.
I think this all makes sense, but I'm still somewhat on the fence. 😇
Distracts from the place where we placed our cursor. I hope that won't be too much of an issue as the currently selected line gets its own highlight.
Yeah, the idea of using only a border for wordHighlight is to avoid clashing with the selection. It should make sure that the selection is still easily visible without overlapping the wordHighlight.
Another reason is that wordHighlight is active by just moving the cursor around. In contrast the selectionHighlight is shown only when making a selection. So using a background for both makes that relationship more clear.
I intentionally put less focus on the
strongword highlight than on the regular one for those reasons
👍 Here another PR that reverts the border/background switch, but makes the "weak" border stronger: https://github.com/dcastil/github-vscode-theme/pull/1
Stronger wordHighlightBorder
|
That makes sense. Let's do it and I can report after a few days if something doesn't feel right. 😊 |
Closes #23, specifically addresses #23 (comment).