Add peekViewEditor colors for dark theme - #39
Conversation
|
hi @simurai , while the default colors seem to work well for the light theme they are a bit off for the dark theme as @orsenkucher pointed out I tried using the same orange as the title for the borders but I thought the default blue looked better instead so I left that one as is |
|
@this-fifo now it looks a lot better bro! |
|
@this-fifo @simurai, I know it can get messed up rly quickly, but we can try to approach highlights like Pop N' Lock did Basically give to it some borders and matching fill color. And maybe switch from orange to bluish green color What do you think? |
|
I added the As for the blueish/distinct background, I opted for something more along the lines of other popular dark themes that rely on the borders to create visual context, here's an example of how it looks like for And for Atom One Dark And now github-vscode-theme |
|
Okey, sounds reasonable) I think this issue received great treatment and is basically ready to merge👍👍 @this-fifo |
simurai
left a comment
There was a problem hiding this comment.
Didn't even know about this. 😅 Another option would be to "raise" the peekViewEditor, but we can consider another time.
Let's get this 🚢 ed. 👍



Fix #38