Enable semantic highlighting - #30
Merged
Merged
Conversation
|
I can confirm this look much better now, thank you (left is before, right is after):
When is this going to ship to the theme in the Code marketplace? |
Contributor
Author
We can publish another release in a few hours. ⏲️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables semantic highlighting. I haven't looked into the details, but I can see a difference with this sample TS code:
I guess semantically it's not a
variablebut apropertythat falls back to thevariable.othercolor? 🤔 Anyways, we can make further tweaks if needed.Closes #25