Sitelet https://github.com/primer/github-vscode-theme/pull/256
Skip to content

Fix Dark Dimmed - #256

Merged
simurai merged 2 commits into
mainfrom
fix-dark-dimmed
Jan 28, 2022
Merged

simurai merged 2 commits into
mainfrom
fix-dark-dimmed

Conversation

@simurai

@simurai simurai commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

This fixes #255.

Seems we forgot to rename dimmed to dark_dimmed in the theme file.

@changeset-bot

changeset-bot Bot commented Jan 28, 2022 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6549f32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jan 28, 2022 •

Copy link
Copy Markdown
Contributor
Colors changed
--- base/themes/dark-dimmed.json	2022-01-28 05:53:17.103588715 +0000
+++ themes/dark-dimmed.json	2022-01-28 05:53:14.615425379 +0000
@@ -111,2 +111,15 @@
     "editorCursor.foreground": "#539bf5",
+    "editor.findMatchBackground": "#ffd33d44",
+    "editor.findMatchHighlightBackground": "#ffd33d22",
+    "editor.linkedEditingBackground": "#3392FF22",
+    "editor.inactiveSelectionBackground": "#3392FF22",
+    "editor.selectionBackground": "#3392FF44",
+    "editor.selectionHighlightBackground": "#17E5E633",
+    "editor.selectionHighlightBorder": "#17E5E600",
+    "editor.wordHighlightBackground": "#17E5E600",
+    "editor.wordHighlightStrongBackground": "#17E5E600",
+    "editor.wordHighlightBorder": "#17E5E699",
+    "editor.wordHighlightStrongBorder": "#17E5E666",
+    "editorBracketMatch.background": "#17E5E650",
+    "editorBracketMatch.border": "#17E5E600",
     "editorGutter.modifiedBackground": "#ae7c1466",
@@ -116,2 +129,7 @@
     "diffEditor.removedTextBackground": "#e5534b26",
+    "scrollbar.shadow": "#0008",
+    "scrollbarSlider.background": "#484F5833",
+    "scrollbarSlider.hoverBackground": "#484F5844",
+    "scrollbarSlider.activeBackground": "#484F5888",
+    "editorOverviewRuler.border": "#1c2128",
     "panel.background": "#1c2128",
@@ -147,2 +165,8 @@
     "debugToolBar.background": "#2d333b",
+    "editor.stackFrameHighlightBackground": "#C6902625",
+    "editor.focusedStackFrameHighlightBackground": "#2b6a3033",
+    "peekViewEditor.matchHighlightBackground": "#ffd33d33",
+    "peekViewResult.matchHighlightBackground": "#ffd33d33",
+    "peekViewEditor.background": "#0d111788",
+    "peekViewResult.background": "#22272e",
     "settings.headerForeground": "#768390",
@@ -160,3 +184,5 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#768390"
+      }
     },
@@ -170,3 +196,5 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -178,3 +206,5 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#f69d50"
+      }
     },
@@ -196,3 +226,5 @@
       "scope": "entity.name.function",
-      "settings": {}
+      "settings": {
+        "foreground": "#dcbdfb"
+      }
     },
@@ -203,3 +235,5 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#8ddb8c"
+      }
     },
@@ -207,3 +241,5 @@
       "scope": "keyword",
-      "settings": {}
+      "settings": {
+        "foreground": "#f47067"
+      }
     },
@@ -214,3 +250,5 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#f47067"
+      }
     },
@@ -232,3 +270,5 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#96d0ff"
+      }
     },
@@ -236,3 +276,5 @@
       "scope": "support",
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -240,3 +282,5 @@
       "scope": "meta.property-name",
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -244,3 +288,5 @@
       "scope": "variable",
-      "settings": {}
+      "settings": {
+        "foreground": "#f69d50"
+      }
     },
@@ -255,3 +301,4 @@
       "settings": {
-        "fontStyle": "italic"
+        "fontStyle": "italic",
+        "foreground": "#ff938a"
       }
@@ -261,3 +308,4 @@
       "settings": {
-        "fontStyle": "italic"
+        "fontStyle": "italic",
+        "foreground": "#ff938a"
       }
@@ -267,3 +315,4 @@
       "settings": {
-        "fontStyle": "italic"
+        "fontStyle": "italic",
+        "foreground": "#ff938a"
       }
@@ -273,3 +322,4 @@
       "settings": {
-        "fontStyle": "italic"
+        "fontStyle": "italic",
+        "foreground": "#ff938a"
       }
@@ -280,2 +330,4 @@
         "fontStyle": "italic underline",
+        "background": "#f47067",
+        "foreground": "#22272e",
         "content": "^M"
@@ -285,3 +337,5 @@
       "scope": "message.error",
-      "settings": {}
+      "settings": {
+        "foreground": "#ff938a"
+      }
     },
@@ -295,3 +349,5 @@
       "scope": "string variable",
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -302,3 +358,5 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#96d0ff"
+      }
     },
@@ -311,3 +369,5 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#96d0ff"
+      }
     },
@@ -316,3 +376,4 @@
       "settings": {
-        "fontStyle": "bold"
+        "fontStyle": "bold",
+        "foreground": "#8ddb8c"
       }
@@ -321,3 +382,5 @@
       "scope": "support.constant",
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -325,3 +388,5 @@
       "scope": "support.variable",
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -329,3 +394,5 @@
       "scope": "meta.module-reference",
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -333,3 +400,5 @@
       "scope": "punctuation.definition.list.begin.markdown",
-      "settings": {}
+      "settings": {
+        "foreground": "#f69d50"
+      }
     },
@@ -341,3 +410,4 @@
       "settings": {
-        "fontStyle": "bold"
+        "fontStyle": "bold",
+        "foreground": "#6cb6ff"
       }
@@ -346,3 +416,5 @@
       "scope": "markup.quote",
-      "settings": {}
+      "settings": {
+        "foreground": "#8ddb8c"
+      }
     },
@@ -364,3 +436,5 @@
       "scope": "markup.raw",
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -372,3 +446,6 @@
       ],
-      "settings": {}
+      "settings": {
+        "background": "#5D0F12",
+        "foreground": "#ff938a"
+      }
     },
@@ -380,3 +457,6 @@
       ],
-      "settings": {}
+      "settings": {
+        "background": "#113417",
+        "foreground": "#8ddb8c"
+      }
     },
@@ -387,3 +467,6 @@
       ],
-      "settings": {}
+      "settings": {
+        "background": "#682d0f",
+        "foreground": "#f69d50"
+      }
     },
@@ -394,3 +477,6 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#2d333b",
+        "background": "#6cb6ff"
+      }
     },
@@ -399,2 +485,3 @@
       "settings": {
+        "foreground": "#dcbdfb",
         "fontStyle": "bold"
@@ -404,3 +491,5 @@
       "scope": "meta.diff.header",
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -409,3 +498,4 @@
       "settings": {
-        "fontStyle": "bold"
+        "fontStyle": "bold",
+        "foreground": "#6cb6ff"
       }
@@ -414,3 +504,5 @@
       "scope": "meta.output",
-      "settings": {}
+      "settings": {
+        "foreground": "#6cb6ff"
+      }
     },
@@ -425,3 +517,5 @@
       ],
-      "settings": {}
+      "settings": {
+        "foreground": "#768390"
+      }
     },
@@ -429,3 +523,5 @@
       "scope": "brackethighlighter.unmatched",
-      "settings": {}
+      "settings": {
+        "foreground": "#ff938a"
+      }
     },
@@ -437,2 +533,3 @@
       "settings": {
+        "foreground": "#96d0ff",
         "fontStyle": "underline"

@simurai
simurai merged commit 5666ad9 into main Jan 28, 2022
@simurai
simurai deleted the fix-dark-dimmed branch January 28, 2022 05:54
@primer-css primer-css mentioned this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dimmed theme is broken in V5.2

1 participant