Sitelet https://github.com/primer/github-vscode-theme/pull/239
Skip to content

Applying theme colors to UI - #239

Merged
simurai merged 3 commits into
primer:mainfrom
jeffgennari:main
Jul 13, 2022
Merged

Applying theme colors to UI#239
simurai merged 3 commits into
primer:mainfrom
jeffgennari:main

Conversation

@jeffgennari

@jeffgennari jeffgennari commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

I customized the theme to be more immersive by coloring debug tokens and symbols. Feel free to take it or leave it

@changeset-bot

changeset-bot Bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d1d663b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeffgennari

jeffgennari commented Apr 1, 2022

Copy link
Copy Markdown
Contributor Author

Just an FYI, I've updated this to work with the theme variables:

      "debugConsole.infoForeground": lightDark( scale.gray[6], scale.gray[3]),
      "debugConsole.warningForeground": lightDark( scale.yellow[6], scale.yellow[3]),
      "debugConsole.errorForeground": lightDark( scale.red[5], scale.red[2]),      
      "debugConsole.sourceForeground": lightDark( scale.yellow[5], scale.yellow[2]),
      "debugConsoleInputIcon.foreground": lightDark( scale.purple[6], scale.purple[3]),

      "debugTokenExpression.name": lightDark(scale.blue[6], scale.blue[2]),
      "debugTokenExpression.value": lightDark(scale.blue[8], scale.blue[1]),
      "debugTokenExpression.string": lightDark(scale.blue[8], scale.blue[1]),
      "debugTokenExpression.boolean": lightDark( scale.green[6], scale.green[2]),
      "debugTokenExpression.number": lightDark( scale.green[6], scale.green[2]),
      "debugTokenExpression.error": lightDark( scale.red[6], scale.red[2]),

      "symbolIcon.arrayForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.booleanForeground": lightDark( scale.blue[6], scale.blue[3]),
      "symbolIcon.classForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.colorForeground": lightDark( scale.blue[8], scale.blue[2]),
      "symbolIcon.constructorForeground": lightDark( scale.purple[8], scale.purple[2]),
      "symbolIcon.enumeratorForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.enumeratorMemberForeground": lightDark( scale.blue[6], scale.blue[3]),
      "symbolIcon.eventForeground": lightDark( scale.gray[6], scale.gray[4]),
      "symbolIcon.fieldForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.fileForeground": lightDark( scale.yellow[6], scale.yellow[3]),
      "symbolIcon.folderForeground": lightDark( scale.yellow[6], scale.yellow[3]),
      "symbolIcon.functionForeground": lightDark( scale.purple[6], scale.purple[3]),
      "symbolIcon.interfaceForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.keyForeground": lightDark( scale.blue[6], scale.blue[3]),
      "symbolIcon.keywordForeground": lightDark( scale.red[6], scale.red[3]),
      "symbolIcon.methodForeground": lightDark( scale.purple[6], scale.purple[3]),
      "symbolIcon.moduleForeground": lightDark( scale.red[6], scale.red[3]),
      "symbolIcon.namespaceForeground": lightDark( scale.red[6], scale.red[3]),
      "symbolIcon.nullForeground": lightDark( scale.blue[6], scale.blue[3]),
      "symbolIcon.numberForeground": lightDark( scale.green[6], scale.green[3]),
      "symbolIcon.objectForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.operatorForeground": lightDark( scale.blue[8], scale.blue[2]),
      "symbolIcon.packageForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.propertyForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.referenceForeground": lightDark( scale.blue[6], scale.blue[3]),
      "symbolIcon.snippetForeground": lightDark( scale.blue[6], scale.blue[3]),
      "symbolIcon.stringForeground": lightDark( scale.blue[8], scale.blue[2]),
      "symbolIcon.structForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.textForeground": lightDark( scale.blue[8], scale.blue[2]),
      "symbolIcon.typeParameterForeground": lightDark( scale.blue[8], scale.blue[2]),
      "symbolIcon.unitForeground": lightDark( scale.blue[6], scale.blue[3]),
      "symbolIcon.variableForeground": lightDark( scale.orange[6], scale.orange[3]),
      "symbolIcon.constantForeground": lightDark( scale.green[6], scale.green),

@simurai

simurai commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

Just an FYI, I've updated this to work with the theme variables:

Ok, thanks. I solved the merge conflicts by using the updated format in #239 (comment).

Mind posting a screenshot? I assume these overrides are mostly for the debug console?

debug-session

@jeffgennari

jeffgennari commented Apr 4, 2022

Copy link
Copy Markdown
Contributor Author

Yes, the updates are mostly to the debug console and "Debug and Run" in the primary side bar. See the screen shot for the Github Dark Default theme.
Screen Shot 2022-04-04 at 5 21 33 AM

simurai
simurai approved these changes Jul 13, 2022
View reviewed changes

@simurai simurai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshot. 🙇

Ok, let's get this into the next release. 👍

@simurai
simurai merged commit 6164157 into primer:main Jul 13, 2022
@primer-css primer-css mentioned this pull request Jul 13, 2022
Merged
@simurai simurai mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simurai simurai simurai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffgennari @simurai