Sitelet https://github.com/primer/github-vscode-theme/pull/17
Skip to content

Decrease whitespace characters color contrast - #17

Merged
simurai merged 1 commit into
primer:masterfrom
raik:master
May 11, 2020
Merged

simurai merged 1 commit into
primer:masterfrom
raik:master

Conversation

@raik

@raik raik commented May 8, 2020

Copy link
Copy Markdown
Contributor

I decreased the whitespace characters contrast. They were bit too visible for users who render them. Used colors from the Primer's color system.

Screenshots of the new colors:

vscode-gh-theme-pr

@simurai simurai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢👍

@simurai
simurai merged commit 71691fb into primer:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants