Use primer's official colors for activity bar, tab & panel borders - #143
Merged
Merged
Conversation
simurai
approved these changes
Apr 15, 2021
simurai
left a comment
Contributor
There was a problem hiding this comment.
👍
In the future, this variable might can be called something more generic.. like color.border.active or so. For now color.underlinenav.borderActive should do it.
Contributor
Author
|
I will keep an eye on updates to primer/primitives and will change if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the use of primer's 'underlinenav.borderActive' color for VSCode's activity bar, tab and panel borders. Currently, all GitHub theme's have a fixed color value of
#f9826cfor these elements, this PR change would apply the correct primer color for all themes.#f78166#f9826c#f78166