This repository was archived by the owner on Jun 28, 2026. It is now read-only.
fix: DynamicDialogRef.onDragStart never emits (#19611) - #19612
Open
gamble4846 wants to merge 1 commit into
Open
Conversation
- Add `onDragStart` output to `p-dialog` and emit it from `initDrag()` - Bridge `(onDragStart)` in `DynamicDialog` to `DynamicDialogRef.dragStart()` - Add unit tests for both components Fixes primefaces#19611 ## Problem `DynamicDialogRef.onDragStart` never emitted in v21 because drag handling moved into `p-dialog`, but only `onDragEnd` was wired through to the ref. ## Test plan - [x] `dialog.spec.ts` — `onDragStart` emission from `initDrag()` - [x] `dynamicdialog.spec.ts` — `onDialogDragStart` forwards to ref - [x] Manual repro: open `DialogService` dialog, drag header, confirm `onDragStart` and `onDragEnd` both fire
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onDragStartoutput top-dialogand emit it frominitDrag()(onDragStart)inDynamicDialogtoDynamicDialogRef.dragStart()Fixes #19611
Problem
DynamicDialogRef.onDragStartnever emitted in v21 because drag handling moved intop-dialog, but onlyonDragEndwas wired through to the ref.Test plan
dialog.spec.ts—onDragStartemission frominitDrag()dynamicdialog.spec.ts—onDialogDragStartforwards to refDialogServicedialog, drag header, confirmonDragStartandonDragEndboth fireDefect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.