Support SHA-256 zero OIDs in pre-push hook - #3748
Closed
dajinzhu wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3664.
The pre-push hook previously treated the all-zero object ID as a hard-coded 40-character SHA-1 value. That breaks branch creation/deletion pushes in SHA-256 repositories.
This change adds a hash-format-independent zero-OID check and covers both local and remote zero-OID cases for 40- and 64-character IDs.
Tests:
pytest tests/commands/hook_impl_test.py -q— 46 passedpytest tests -q --ignore=tests/languages— 649 passed, 1 skipped, 3 xfailedgit diff --checkpassed