Sitelet https://github.com/pipe-cd/pipecd/pull/70
Skip to content

Remove dev-config.yaml from testdata - #70

Merged
pipecd-bot merged 1 commit into
masterfrom
testdata
Jun 17, 2020
Merged

pipecd-bot merged 1 commit into
masterfrom
testdata

Conversation

@nghialv

@nghialv nghialv commented Jun 17, 2020

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv

nghialv commented Jun 17, 2020

Copy link
Copy Markdown
Member Author

/cc @nakabonne

@pipecd-bot
pipecd-bot requested review from nakabonne and removed request for cakecatz June 17, 2020 05:46
@pipecd-bot

Copy link
Copy Markdown
Collaborator

COVERAGE

Code coverage for golang is 25.67%. This pull request does not change code coverage.

@nakabonne

Copy link
Copy Markdown
Member

I also thought the piped config for dev shouldn't be shared. Nice.
/approve

@pipecd-bot

Copy link
Copy Markdown
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
pipecd-bot merged commit a52f170 into master Jun 17, 2020
@pipecd-bot
pipecd-bot deleted the testdata branch June 17, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants