Issue #1646 - #1650
Merged
Merged
Issue #1646#1650
Conversation
yatsukhnenko
force-pushed
the
issue-1646
branch
from
October 9, 2019 21:02
7cbd293 to
055c549
Compare
NOTE: [This comment](https://github.com/antirez/redis/pull/6116#issuecomment-509331565) indicates the feature may be backported to Redis 5, so we'll want to change our unit test if that happens.
michael-grunder
approved these changes
Oct 10, 2019
Member
|
This change seems fine to me and I think you're right that it's not a breaking change. Really the only question is whether we should take a free-form string for I don't really have a strong opinion on the matter. I suppose using the constants could be useful if people ever wanted to use the result from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TYPE param to SCAN command.
Arginfo wasn't updated so this change isn't breaking change :)