Conversation
Member
|
@fmk thanks! But this change isn't compatible with all previous versions of PHP. |
Author
|
I have tested this with PHP 7.1, 7.2 and 7.3-dev and they all work. What are the errors? |
Author
|
I swapped the logic for checking the version. It should now compile with version 5x and 7.x. |
remicollet
reviewed
Dec 15, 2017
| if (url->query != NULL) { | ||
| array_init(¶ms); | ||
|
|
||
| #if (PHP_MAJOR_VERSION == 7) && (PHP_MINOR_VERSION > 2) |
Collaborator
There was a problem hiding this comment.
IMHO, using PHP_VERSION_ID is simpler (and will take care of PHP 8)
Member
There was a problem hiding this comment.
Agree with @remicollet , something like #if (PHP_VERSION_ID < 70300) would be much better
Member
|
@fmk Could you modify your PR to use PHP_VERSION_ID and squash commits? I'm going to merge this and release 3.1.5 as stable on PECL site. |
yatsukhnenko
added a commit
that referenced
this pull request
Dec 20, 2017
Member
|
I've made changes by myself. Thanks! |
yatsukhnenko
added a commit
that referenced
this pull request
Dec 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default branch was showing warnings when compiling with PHP 7.3-dev and the session handler was no working. Adding ZSTR_VAL() and ZSTR_LEN() macros in 3 lines fixed the problems.