WIP: Patch for mojave - #544
Open
mizunashi-mana wants to merge 3 commits into
Open
mizunashi-mana wants to merge 3 commits into
mizunashi-mana wants to merge 3 commits into
Conversation
mizunashi-mana
force-pushed
the
for-mojave
branch
from
April 17, 2019 04:49
4089f6a to
f975f8d
Compare
Member
|
Wow, this is a lot of patches to maintain. |
Contributor
Author
Yeah. And, these patches have complexity. I avoid to commit such patches if there are another better solutions. We need anyone help. |
|
@mizunashi-mana thank you so much for your contribution, as soon as I have a moment I will have a look at this and consider if this is the right way or if maybe we can come up with a better way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #543
This is working in progress. Do not merge.