Sitelet https://github.com/openwrt/openwrt/pull/23184
Skip to content

github: extend LLM review rules with three new categories - #23184

Merged
openwrt-bot merged 1 commit into
openwrt:mainfrom
hauke:claude-code-routines-update
May 1, 2026
Merged

openwrt-bot merged 1 commit into
openwrt:mainfrom
hauke:claude-code-routines-update

Conversation

@hauke

@hauke hauke commented May 1, 2026

Copy link
Copy Markdown
Member

Tightened from real bot reviews:

  • Patch regeneration: spell out which make ... refresh command to recommend for each patch directory class, so the bot stops suggesting git format-patch for quilt-managed patches.
  • Backports / cherry-picks: a backport's diff should match the upstream commit on main verbatim; flag only deviations and the missing (cherry picked from commit ) trailer, not pre-existing style issues.
  • New device support: require Hardware specification, Flash instructions, and MAC address layout sections in the commit message that introduces a new device. Two reference commits (986ca4c, a2dcbd7) named so the bot can sample the expected shape.

@hauke
hauke force-pushed the claude-code-routines-update branch from 53c06fa to 2befefa Compare May 1, 2026 16:54
@github-actions github-actions Bot added the GitHub/CI pull requests/issues for GitHub, CI and related stuff label May 1, 2026

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


To address review feedback, force-push fixes to this branch. Don't close and open a new PR — that loses the review history and the bot starts from scratch.


Generated by Claude Code

Comment thread .github/llm-review-rules.md Outdated
Comment thread .github/llm-review-rules.md Outdated
@hauke
hauke force-pushed the claude-code-routines-update branch from 2befefa to 02a152f Compare May 1, 2026 17:36
Tightened from real bot reviews:

- Patch regeneration: spell out which make ... refresh command
  to recommend for each patch directory class, so the bot stops
  suggesting git format-patch for quilt-managed patches.
- Backports / cherry-picks: a backport's diff should match the
  upstream commit on main verbatim; flag only deviations and
  the missing (cherry picked from commit <sha>) trailer, not
  pre-existing style issues.
- New device support: require Hardware specification, Flash
  instructions, and MAC address layout sections in the commit
  message that introduces a new device. Two reference commits
  (986ca4c, a2dcbd7) named so the bot can sample the
  expected shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Link: openwrt#23184
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
@hauke
hauke force-pushed the claude-code-routines-update branch from 02a152f to 0bef741 Compare May 1, 2026 18:14
@openwrt-bot
openwrt-bot merged commit 0bef741 into openwrt:main May 1, 2026
3 checks passed
@hauke
hauke deleted the claude-code-routines-update branch May 2, 2026 10:05
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 4, 2026
Tightened from real bot reviews:

- Patch regeneration: spell out which make ... refresh command
  to recommend for each patch directory class, so the bot stops
  suggesting git format-patch for quilt-managed patches.
- Backports / cherry-picks: a backport's diff should match the
  upstream commit on main verbatim; flag only deviations and
  the missing (cherry picked from commit <sha>) trailer, not
  pre-existing style issues.
- New device support: require Hardware specification, Flash
  instructions, and MAC address layout sections in the commit
  message that introduces a new device. Two reference commits
  (986ca4c, a2dcbd7) named so the bot can sample the
  expected shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Link: openwrt#23184
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
db4rne pushed a commit to db4rne/openwrt that referenced this pull request May 4, 2026
Tightened from real bot reviews:

- Patch regeneration: spell out which make ... refresh command
  to recommend for each patch directory class, so the bot stops
  suggesting git format-patch for quilt-managed patches.
- Backports / cherry-picks: a backport's diff should match the
  upstream commit on main verbatim; flag only deviations and
  the missing (cherry picked from commit <sha>) trailer, not
  pre-existing style issues.
- New device support: require Hardware specification, Flash
  instructions, and MAC address layout sections in the commit
  message that introduces a new device. Two reference commits
  (986ca4c, a2dcbd7) named so the bot can sample the
  expected shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Link: openwrt#23184
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
sp4rkiop pushed a commit to sp4rkiop/openwrt that referenced this pull request May 4, 2026
Tightened from real bot reviews:

- Patch regeneration: spell out which make ... refresh command
  to recommend for each patch directory class, so the bot stops
  suggesting git format-patch for quilt-managed patches.
- Backports / cherry-picks: a backport's diff should match the
  upstream commit on main verbatim; flag only deviations and
  the missing (cherry picked from commit <sha>) trailer, not
  pre-existing style issues.
- New device support: require Hardware specification, Flash
  instructions, and MAC address layout sections in the commit
  message that introduces a new device. Two reference commits
  (986ca4c, a2dcbd7) named so the bot can sample the
  expected shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Link: openwrt#23184
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
dchard pushed a commit to dchard/openwrt that referenced this pull request May 15, 2026
Tightened from real bot reviews:

- Patch regeneration: spell out which make ... refresh command
  to recommend for each patch directory class, so the bot stops
  suggesting git format-patch for quilt-managed patches.
- Backports / cherry-picks: a backport's diff should match the
  upstream commit on main verbatim; flag only deviations and
  the missing (cherry picked from commit <sha>) trailer, not
  pre-existing style issues.
- New device support: require Hardware specification, Flash
  instructions, and MAC address layout sections in the commit
  message that introduces a new device. Two reference commits
  (986ca4c, a2dcbd7) named so the bot can sample the
  expected shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Link: openwrt#23184
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Ansuel pushed a commit to BKPepe/openwrt that referenced this pull request Jul 20, 2026
Tightened from real bot reviews:

- Patch regeneration: spell out which make ... refresh command
  to recommend for each patch directory class, so the bot stops
  suggesting git format-patch for quilt-managed patches.
- Backports / cherry-picks: a backport's diff should match the
  upstream commit on main verbatim; flag only deviations and
  the missing (cherry picked from commit <sha>) trailer, not
  pre-existing style issues.
- New device support: require Hardware specification, Flash
  instructions, and MAC address layout sections in the commit
  message that introduces a new device. Two reference commits
  (986ca4c, a2dcbd7) named so the bot can sample the
  expected shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Link: openwrt#23184
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
(cherry picked from commit 0bef741)
Link: openwrt#24318
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
liudf0716 pushed a commit to liudf0716/chawrt that referenced this pull request Jul 21, 2026
Tightened from real bot reviews:

- Patch regeneration: spell out which make ... refresh command
  to recommend for each patch directory class, so the bot stops
  suggesting git format-patch for quilt-managed patches.
- Backports / cherry-picks: a backport's diff should match the
  upstream commit on main verbatim; flag only deviations and
  the missing (cherry picked from commit <sha>) trailer, not
  pre-existing style issues.
- New device support: require Hardware specification, Flash
  instructions, and MAC address layout sections in the commit
  message that introduces a new device. Two reference commits
  (986ca4c887f4, a2dcbd79a446) named so the bot can sample the
  expected shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Link: openwrt/openwrt#23184
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
(cherry picked from commit 0bef7411885e9f6e4d4f4224ec4a94565396010f)
Link: openwrt/openwrt#24318
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
(cherry picked from commit d9a0d02ef46d7f46b9aeafcbb15cf471f2cc7a65)
LuisMitaHL pushed a commit to LuisMitaHL/LooperWrt that referenced this pull request Sep 21, 2026
Tightened from real bot reviews:

- Patch regeneration: spell out which make ... refresh command
  to recommend for each patch directory class, so the bot stops
  suggesting git format-patch for quilt-managed patches.
- Backports / cherry-picks: a backport's diff should match the
  upstream commit on main verbatim; flag only deviations and
  the missing (cherry picked from commit <sha>) trailer, not
  pre-existing style issues.
- New device support: require Hardware specification, Flash
  instructions, and MAC address layout sections in the commit
  message that introduces a new device. Two reference commits
  (986ca4c, a2dcbd7) named so the bot can sample the
  expected shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Link: openwrt#23184
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
(cherry picked from commit 0bef741)
Link: openwrt#24318
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
oxavelar pushed a commit to oxavelar/openwrt that referenced this pull request Sep 22, 2026
Tightened from real bot reviews:

- Patch regeneration: spell out which make ... refresh command
  to recommend for each patch directory class, so the bot stops
  suggesting git format-patch for quilt-managed patches.
- Backports / cherry-picks: a backport's diff should match the
  upstream commit on main verbatim; flag only deviations and
  the missing (cherry picked from commit <sha>) trailer, not
  pre-existing style issues.
- New device support: require Hardware specification, Flash
  instructions, and MAC address layout sections in the commit
  message that introduces a new device. Two reference commits
  (986ca4c, a2dcbd7) named so the bot can sample the
  expected shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Link: openwrt#23184
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
(cherry picked from commit 0bef741)
Link: openwrt#24318
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GitHub/CI pull requests/issues for GitHub, CI and related stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants